Prewarm LLM cache #6692
Merged
Prewarm LLM cache #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
commented
May 30, 2025
|
|
||
| @cache | ||
|
|
||
| @lru_cache(maxsize=1) |
There was a problem hiding this comment.
cache is basically lru_cache(maxsize=None)
escattone
approved these changes
May 30, 2025
escattone
reviewed
May 30, 2025
| @@ -1337,8 +1337,6 @@ def filter_exceptions(event, hint): | |||
|
|
|||
| USER_INACTIVITY_DAYS = config("USER_INACTIVITY_DAYS", default=1095, cast=int) | |||
|
|
|||
| if DEV: | |||
| GOOGLE_APPLICATION_CREDENTIALS = config("GOOGLE_APPLICATION_CREDENTIALS", default="") | |||
There was a problem hiding this comment.
GOOGLE_APPLICATION_CREDENTIALS is only needed for local development, and doesn't have to be added to settings even for that case. It's never used within the dev, stage, or prod environments.
|
I love the idea of this, but it re-introduces the slow start-up issue that caused our deployment problems. I'm going to revert this. I don't think we need this anyway, because we're not really concerned with the initial startup cost when making the first LLM call. |
escattone
added a commit
that referenced
this pull request
May 30, 2025
This reverts commit c055b04.
escattone
added a commit
that referenced
this pull request
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.